-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to use ECMAScript 2015 Object.assign. #14
Conversation
Updated pbxproj.js to use ECMAScript 2015 Object.assign to avoid Maximum call stack size exceeded error when running react-native link.
Thanks for the PR!
Can you elaborate on that? Those names mean nothing to me. |
Yea sure, Ignite Bowser is a popular boilerplate template for React Native. It just helps you spin up a project with all the essential dependencies and boilerplate code for a proper (read not prototype) project. You can see they have an issue open here: infinitered/ignite-bowser#120 I will link this PR in the issue. |
Ok thanks. Can you point me to where this library here is defined and used as a dependency in this boilerplate code? I am a bit confused by the stacktrace |
Another thing is that the proposed change would require us to drop support for older Node.js versions, which would need to be done in a major release, as I proposed in #20. (There may still be some non-Cordova using this package on older Node.js versions, which we should not break according to I am also looking forward to the answer to the latest question by @janpio. P.S. I found a "ponyfill" at https://github.com/sindresorhus/object-assign in case it may help us with Node.js pre-4.0. |
Apologies for the delay in response. You are spot on, it isn't referenced directly in the boilerplate template. I actually went and looked through the dependencies and it looks like the library is a dependency of react-native and of appcenter-link-scripts in my specific project. There are quite a few of these I will probably have more time over the weekend to investigate what exactly was causing this error in my environment. At this point I can't be sure that the fix in this PR resolves the underlying issue, it just might be moving it further downstream. However it does help remove a good 12 lines of code ;) Whether that is worth the risk of dropping support for older version of Node is up for discussion. |
Travis CI passes if I merge this change in my own workarea: https://travis-ci.org/brodybits/cordova-node-xcode/builds/470183332, merging now. |
@RokoBasilisk I did a squash merge so your
|
(Or just get rid of your fork and create a new one if you need it again 🙊) |
Updated pbxproj.js to use ECMAScript 2015 Object.assign to avoid Maximum call stack size exceeded error when running react-native link.
I was getting the above error when running link in the Ignite Bowser template. This fix resolved that. Object.assign targets ECMAScript 2015 though so I see how that might be an issue if you want to target previous versions.