Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump node requirement (>=10) #92

Merged
merged 1 commit into from
Mar 30, 2020
Merged

chore: bump node requirement (>=10) #92

merged 1 commit into from
Mar 30, 2020

Conversation

timbru31
Copy link
Member

No description provided.

@timbru31 timbru31 mentioned this pull request Mar 28, 2020
Closed
@timbru31 timbru31 linked an issue Mar 28, 2020 that may be closed by this pull request
[MAJOR] Drop support for Node.js 6 & 8 #77
Closed
@brodycj
Copy link

brodycj commented Mar 29, 2020

I wouldn't mind if we could consider please-upgrade-node, which I recently discovered from prettier/prettier#7837.

@timbru31 timbru31 marked this pull request as ready for review March 30, 2020 10:42
@timbru31
Copy link
Member Author

Thanks for the hint Brody. Would evaluate "please-upgrade-node" in a separate PR though.

@timbru31 timbru31 merged commit 2937386 into master Mar 30, 2020
@timbru31 timbru31 deleted the feat/drop-node-lower-10 branch March 30, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MAJOR] Drop support for Node.js 6 & 8
3 participants
@timbru31 @brodycj @erisu