Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13865: (IOS-Ipad) Making popover Window Size configurable using popoverOptions - imagePicker #314

Merged

Conversation

amercode
Copy link
Contributor

Platforms affected

IOS - Ipad only

What does this PR do?

Allow the user to set the popover Width and Height on Ipads

What testing has been done on this change?

Modified the automated test cases to accommodate for the change.
Tested the plugin on the Ipad with different popover height and width as well as not specifying any.

Checklist

  • [x ] Reported an issue in the JIRA database
  • [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • [ x] Added automated test coverage as appropriate for this change.

@amercode amercode changed the title CB-13865: (IOS-Ipad) Making CameraPopover for imagePicker bigger on Ipad CB-13865: (IOS-Ipad) Allowing user to specify popover Window Size in popoverOptions Feb 28, 2018
@amercode amercode changed the title CB-13865: (IOS-Ipad) Allowing user to specify popover Window Size in popoverOptions CB-13865: (IOS-Ipad) Making popover Window Size configurable using popoverOptions Feb 28, 2018
@amercode amercode force-pushed the CB-13865cordova-plugin-camera_PopoverSize branch from 31ea3ad to b747d58 Compare February 28, 2018 04:44
@amercode amercode changed the title CB-13865: (IOS-Ipad) Making popover Window Size configurable using popoverOptions CB-13865: (IOS-Ipad) Making popover Window Size configurable using popoverOptions - imagePicker Feb 28, 2018
@amercode amercode force-pushed the CB-13865cordova-plugin-camera_PopoverSize branch from b747d58 to 4c76b6e Compare February 28, 2018 04:50
@amercode
Copy link
Contributor Author

Travis Build failed due to timeout on the server and not due to test cases failing. It failed only for android-6.0 and android-7.0 while passing for all other platforms including android-4.4 and android-5.1.

We have not made any changes in the Android code and it is clearly a build server timeout probably due to overload. Is there a way to retrigger the build or make those test cases pass? Please advise as you can see the logs below for the failed test case?

....................................................................................................................................................................................................................... ✗ camera.ui.util determine camera availability
- Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
...................................................................................................................

@alsorokin
Copy link
Contributor

I've restarted the failed jobs and they are green now.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcesarmobile jcesarmobile merged commit cd72047 into apache:master Nov 25, 2018
@08Thug
Copy link

08Thug commented Mar 30, 2020

i edited the plugin as you did but still cant access popoverwidth and popoverheight
it says

Type '{ x: number; y: number; width: number; height: number; arrowDir: number; popoverWidth: number; popoverHeight: number; }' is not assignable to type 'CameraPopoverOptions'.
Object literal may only specify known properties, and 'popoverWidth' does not exist in type 'CameraPopoverOptions'.ts(2322)

any help from the editor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants