CB-14097: (android) Fix crash when selecting some files with getPicture #322

bvmensvoort · 2018-05-18T08:12:04Z

Handles both urls:
content://com.android.providers.downloads.documents/document/1111
content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf

Platforms affected

Android

What does this PR do?

Fixes crash of certain URLs

What testing has been done on this change?

manual testing

Checklist

[ x ] Reported an issue in the JIRA database
[ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ? ] Added automated test coverage as appropriate for this change.

…re of urls with raw:// Handles both urls: content://com.android.providers.downloads.documents/document/1111 content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf

ochakov · 2018-07-01T20:02:40Z

Happened to me when selecting a photo from the Downloads folder.
Please merge this fix.
+1

jcesarmobile

Looks good, but can you do the two changes I requested?

jcesarmobile · 2018-07-01T20:10:50Z

src/android/FileHelper.java

-                        Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));
-
-                return getDataColumn(context, contentUri, null, null);
+                if (!TextUtils.isEmpty(id)) {


Instead of using TextUtils just for checking if is empty, use id != null && id.length() > 0

Good idea to remove the dependency

jcesarmobile · 2018-07-01T20:11:23Z

src/android/FileHelper.java

+                    } catch (NumberFormatException e) {
+                        return null;
+                    }
+                }


if id is empty return null too

…ld be extracted

bvmensvoort · 2018-07-05T14:56:45Z

I have implemented the suggestions of the review.
Must be better now.

jcesarmobile · 2018-07-05T22:17:17Z

Thanks, merged!

jwburnside · 2018-08-14T20:43:03Z

Is there a timeline for the next release? We're on 4.0.3 but this hasn't been merged in yet apparently.

jcesarmobile · 2018-08-14T22:19:12Z

It’s merged, but not released

jordanorc · 2019-03-26T20:39:07Z

Is there a timeline for the next release?

osa-aq · 2019-03-31T16:00:12Z

This is very important, The camera is not working on a lot of android devices, When this will be released ?

dusty-java-cup · 2019-04-20T03:09:26Z

I need this fix. Please let me know how I can get around this problem. Is there a way I can manually apply this fix to my version of the plugin?

android). PROBLEM, the plugins/cordova-plugin-camera has a bug in it that causes a problem with file paths (apache/cordova-plugin-camera#322). I had to add the fix manually then run the following commands: ionic cordova platform rm android (OR IOS) ionic cordova build android (OR IOS). Still need to implement the image upload.

rodrigograca31 · 2019-06-21T09:52:43Z

I'm also facing this issue.

We need this fix released!
There hasn't been a release in more than one year! We need it badly!

claudiozam · 2019-06-27T11:36:50Z

I'm also facing this issue.
Is there a timeline for the next release?
Thanks

rodrigograca31 · 2019-06-27T14:43:50Z

@claudiozam probably no timeline.

I'm considering to use this repo directly to pull this fix to my code.....

rodrigograca31 · 2019-06-29T00:09:32Z

Actually we just got a release!!!! @claudiozam

Thanks to @janpio ❤️ 🎉

janpio · 2019-06-29T09:53:39Z

Just a tag for now, release is in vote but will follow soon-ish. Watch for the rel/x.y.z tag that is made after it has been published to npm.

rodrigograca31 · 2019-06-29T17:25:03Z

@janpio isnt a tag a release?
At least for me it is.... if I add the plugin it will add it like cordova-plugin-camera@4.1.0 ......

janpio · 2019-06-29T18:59:50Z

No, a tag is just a tag - but of course that can also be installed with the CLI. But doing cordova plugin add cordova-plugin-camera will only install tags that are also published to npm - and there it will take a few days until I can do that after a successful vote.

rodrigograca31 · 2019-06-30T10:53:35Z

Maybe its because I used ionic but ionic cordova plugin add cordova-plugin-camera installs 4.1.0 directly from here

rodrigograca31 · 2019-06-30T11:03:40Z

Oh wait! I was wrong!
Seems it installs ^4.0.3 .... I dont know why but I thought it was installing 4.1.0.

Can we see the vote status? Where?

Thanks!

jcesarmobile · 2019-06-30T11:36:53Z

https://lists.apache.org/thread.html/8aa8a73bd1b6b39c58de3a666f69311bec865985c71ccdc3523f6d0e@%3Cdev.cordova.apache.org%3E

giuseeFG · 2019-11-20T14:13:13Z

I solved it by editing the method "getRealPathFromURI_API11_And_Above" in this way:

@SuppressLint("NewApi")
    public static String getRealPathFromURI_API11_And_Above(final Context context, final Uri uri) {
        final boolean isKitKat = Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT;
        // DocumentProvider
        if (isKitKat && DocumentsContract.isDocumentUri(context, uri)) {

            // ExternalStorageProvider
            if (isExternalStorageDocument(uri)) {
                final String docId = DocumentsContract.getDocumentId(uri);
                final String[] split = docId.split(":");
                final String type = split[0];

                if ("primary".equalsIgnoreCase(type)) {
                    return Environment.getExternalStorageDirectory() + "/" + split[1];
                }

                // TODO handle non-primary volumes
            }
           /* // DownloadsProvider
            else if (isDownloadsDocument(uri)) {

                final String id = DocumentsContract.getDocumentId(uri);
                if (id != null && id.length() > 0) {
                    if (id.startsWith("raw:")) {
                        return id.replaceFirst("raw:", "");
                    }
                    try {
                        final Uri contentUri = ContentUris.withAppendedId(
                                Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));

                        return getDataColumn(context, contentUri, null, null);
                    } catch (NumberFormatException e) {
                        return null;
                    }
                } else {
                    return null;
                }
            }*/
            // MediaProvider
            else if (isMediaDocument(uri) || isDownloadsDocument(uri)) {
                String docId = DocumentsContract.getDocumentId(uri);
                docId = docId.replace("msf:", "video:");
                final String[] split = docId.split(":");
                final String type = split[0];

                Uri contentUri = null;
                if ("image".equals(type)) {
                    contentUri = MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
                } else if ("video".equals(type)) {
                    contentUri = MediaStore.Video.Media.EXTERNAL_CONTENT_URI;
                } else if ("audio".equals(type)) {
                    contentUri = MediaStore.Audio.Media.EXTERNAL_CONTENT_URI;
                }

                final String selection = "_id=?";
                final String[] selectionArgs = new String[]{
                        split[1]
                };

                return getDataColumn(context, contentUri, selection, selectionArgs);
            }
        }
        // MediaStore (and general)
        else if ("content".equalsIgnoreCase(uri.getScheme())) {

            // Return the remote address
            if (isGooglePhotosUri(uri))
                return uri.getLastPathSegment();

            return getDataColumn(context, uri, null, null);
        }
        // File
        else if ("file".equalsIgnoreCase(uri.getScheme())) {
            return uri.getPath();
        }

        return null;
    }

vo-va · 2020-07-14T10:04:14Z

Hi @giuseeFG, your snippet helped me, thank you.
One question did you create pull request with it? If not I want to do it.

jcesarmobile requested changes Jul 1, 2018

View reviewed changes

Optimization: Remove TextUtils dependency, return null when no id cou…

4d3a4af

…ld be extracted

jcesarmobile approved these changes Jul 5, 2018

View reviewed changes

jcesarmobile merged commit 5c23b65 into apache:master Jul 5, 2018

bvmensvoort deleted the Fix-for-CB-14097 branch September 28, 2018 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CB-14097: (android) Fix crash when selecting some files with getPicture #322

CB-14097: (android) Fix crash when selecting some files with getPicture #322

bvmensvoort commented May 18, 2018

ochakov commented Jul 1, 2018

jcesarmobile left a comment

jcesarmobile Jul 1, 2018 •

edited

Loading

bvmensvoort Jul 5, 2018

jcesarmobile Jul 1, 2018

bvmensvoort commented Jul 5, 2018

jcesarmobile commented Jul 5, 2018

jwburnside commented Aug 14, 2018

jcesarmobile commented Aug 14, 2018

jordanorc commented Mar 26, 2019

osa-aq commented Mar 31, 2019

dusty-java-cup commented Apr 20, 2019

rodrigograca31 commented Jun 21, 2019

claudiozam commented Jun 27, 2019

rodrigograca31 commented Jun 27, 2019

rodrigograca31 commented Jun 29, 2019

janpio commented Jun 29, 2019

rodrigograca31 commented Jun 29, 2019

janpio commented Jun 29, 2019

rodrigograca31 commented Jun 30, 2019 •

edited

Loading

rodrigograca31 commented Jun 30, 2019

jcesarmobile commented Jun 30, 2019

giuseeFG commented Nov 20, 2019 •

edited

Loading

vo-va commented Jul 14, 2020 •

edited

Loading

CB-14097: (android) Fix crash when selecting some files with getPicture #322

CB-14097: (android) Fix crash when selecting some files with getPicture #322

Conversation

bvmensvoort commented May 18, 2018

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

ochakov commented Jul 1, 2018

jcesarmobile left a comment

Choose a reason for hiding this comment

jcesarmobile Jul 1, 2018 • edited Loading

Choose a reason for hiding this comment

bvmensvoort Jul 5, 2018

Choose a reason for hiding this comment

jcesarmobile Jul 1, 2018

Choose a reason for hiding this comment

bvmensvoort commented Jul 5, 2018

jcesarmobile commented Jul 5, 2018

jwburnside commented Aug 14, 2018

jcesarmobile commented Aug 14, 2018

jordanorc commented Mar 26, 2019

osa-aq commented Mar 31, 2019

dusty-java-cup commented Apr 20, 2019

rodrigograca31 commented Jun 21, 2019

claudiozam commented Jun 27, 2019

rodrigograca31 commented Jun 27, 2019

rodrigograca31 commented Jun 29, 2019

janpio commented Jun 29, 2019

rodrigograca31 commented Jun 29, 2019

janpio commented Jun 29, 2019

rodrigograca31 commented Jun 30, 2019 • edited Loading

rodrigograca31 commented Jun 30, 2019

jcesarmobile commented Jun 30, 2019

giuseeFG commented Nov 20, 2019 • edited Loading

vo-va commented Jul 14, 2020 • edited Loading

jcesarmobile Jul 1, 2018 •

edited

Loading

rodrigograca31 commented Jun 30, 2019 •

edited

Loading

giuseeFG commented Nov 20, 2019 •

edited

Loading

vo-va commented Jul 14, 2020 •

edited

Loading