-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI API called on a background thread (#550, #530, #447) #551
Conversation
Thanks for the PR. Seems like there was a lot of confusion here for managing these tickets, between issues being closed prematurely even an existing PR was closed prematurely... For github to recognise which issues this PR resolves, please edit it so it includes "fixes ", note that you need to repeat this format for each issue
See https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords for more information. Also I believe this PR will address #447 as well, please confirm for me. |
Yes. Thank you. I've added it to the description as well. |
When is this update expected to be released? |
Please merge these fixes as this camera delay opening is a real trouble making in may devices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:
- Used demo project from First camera.getPicture() costs 10 or more seconds to open native camera #447
- Error message is fixed, Xcode no longer complains after moving the block
- Camera startup is no longer 10s
When is version 4.2.0 going to be released to npm? Why the delay? |
4.2.0 is broken and failed release vote. |
Platforms affected
iOS
Motivation and Context
It fixes #530, fixes #550, fixes #447, fixes #509, fixes #515
Description
The plugin initializes a picker in the main thread now.
Previously made pull request by @ryaa: ryaa@a998ef4
Testing
I've launched my app and tried to start camera session. It is ok now. No exceptions or low speed.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)