Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI API called on a background thread (#550, #530, #447) #551

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Fix UI API called on a background thread (#550, #530, #447) #551

merged 1 commit into from
Apr 9, 2020

Conversation

exxbrain
Copy link
Contributor

@exxbrain exxbrain commented Jan 22, 2020

Platforms affected

iOS

Motivation and Context

It fixes #530, fixes #550, fixes #447, fixes #509, fixes #515

Description

The plugin initializes a picker in the main thread now.
Previously made pull request by @ryaa: ryaa@a998ef4

Testing

I've launched my app and tried to start camera session. It is ok now. No exceptions or low speed.

Checklist

  • I've run the tests to see all new and existing tests pass
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@exxbrain exxbrain requested a review from timbru31 January 22, 2020 15:35
@breautek
Copy link
Contributor

breautek commented Jan 23, 2020

Thanks for the PR. Seems like there was a lot of confusion here for managing these tickets, between issues being closed prematurely even an existing PR was closed prematurely...

For github to recognise which issues this PR resolves, please edit it so it includes "fixes ", note that you need to repeat this format for each issue

fixes #issue
fixes #issue

See https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords for more information.

Also I believe this PR will address #447 as well, please confirm for me.

@exxbrain
Copy link
Contributor Author

exxbrain commented Jan 23, 2020

Also I believe this PR will address #447 as well, please confirm for me.

Yes. Thank you. I've added it to the description as well.

@exxbrain exxbrain changed the title Fix UI API called on a background thread (#550, #530) Fix UI API called on a background thread (#550, #530, #447) Jan 23, 2020
@exxbrain exxbrain requested review from jcesarmobile and timbru31 and removed request for timbru31 January 23, 2020 17:09
sarunyool pushed a commit to sarunyool/cordova-plugin-camera that referenced this pull request Feb 14, 2020
@stevenleija
Copy link

When is this update expected to be released?

@gvsakhil
Copy link

gvsakhil commented Apr 9, 2020

Please merge these fixes as this camera delay opening is a real trouble making in may devices

@jcesarmobile jcesarmobile removed their request for review April 9, 2020 11:38
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

@timbru31 timbru31 merged commit f4067e2 into apache:master Apr 9, 2020
@AndrWeisR
Copy link

When is version 4.2.0 going to be released to npm? Why the delay?

@erisu
Copy link
Member

erisu commented Aug 10, 2020

4.2.0 is broken and failed release vote.

@apache apache locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants