fix(android): file path correction if Uri authority is FileProvider

[Suzzak]

Platforms affected

Android

Motivation and Context

Select some videos or images return path error when Uri authority is FileProvider, then the app restarts.. That's why this bug is not always happening but it can be really annoying.

It's probably fixing the following issues (hard to say some descriptions are rather short): Resolves #573, resolves #531, resolves #548, resolves #554, resolves #558, resolves #563

Description

Checking if Uri authority is FileProvider for MediaStore content then find the URI.

Testing

Tested with most of my user's app and with my Huawei p smart 2019 - Android 10 and with Samsung Galaxy S5.

Checklist

• I've run the tests to see all new and existing tests pass
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

[breautek]

It looks good, do you know if there is a test app available that shows the reproduction of the original issue?

Edit: The sample code #531 worked for me to reproduce this issue

[breautek]

Thank you for your contribution.

Was able to reproduce the issue using some sample codes provided in the linked issues. Confirmed that this PR addresses the problem. 👍

I would like to see a review from at least one other member before I merge.

[isamuAsial]

Please merge it. It seems good enough change and the current Android camera is useless.

[sirhaplo]

I used this PR to try if it resolves the issue #554 but the problem is still here.
I ( and other people ) think that is not a problem about uri

[robinparadise]

Guys, any update about this 🥶?

I've tried @timbru31 fileHelper.java and it doesn't work

Thanks

[robinparadise]

I fixed with this code:

public static String getFilePath(Context context, Uri uri) {

    Cursor cursor = null;
    final String[] projection = {
      MediaStore.MediaColumns.DISPLAY_NAME
    };

    try {
      cursor = context.getContentResolver().query(uri, projection, null, null,
        null);
      if (cursor != null && cursor.moveToFirst()) {
        final int index = cursor.getColumnIndexOrThrow(MediaStore.MediaColumns.DISPLAY_NAME);
        return cursor.getString(index);
      }
    } finally {
      if (cursor != null)
        cursor.close();
    }
    return null;
  }

..................

      // DownloadsProvider
      else if (isDownloadsDocument(uri)) {
        String fileName = getFilePath(context, uri);
        if (fileName != null) {
          return Environment.getExternalStorageDirectory().toString() + "/Download/" + fileName;
        }
........................

[sylber-cz]

Any update on this?

I fixed with this code:

public static String getFilePath(Context context, Uri uri) {

    Cursor cursor = null;
    final String[] projection = {
      MediaStore.MediaColumns.DISPLAY_NAME
    };

    try {
      cursor = context.getContentResolver().query(uri, projection, null, null,
        null);
      if (cursor != null && cursor.moveToFirst()) {
        final int index = cursor.getColumnIndexOrThrow(MediaStore.MediaColumns.DISPLAY_NAME);
        return cursor.getString(index);
      }
    } finally {
      if (cursor != null)
        cursor.close();
    }
    return null;
  }

..................

      // DownloadsProvider
      else if (isDownloadsDocument(uri)) {
        String fileName = getFilePath(context, uri);
        if (fileName != null) {
          return Environment.getExternalStorageDirectory().toString() + "/Download/" + fileName;
        }
........................

Can you share your FileHelper.java file?

[robinparadise]

@sylber-cz here is my fileHelper.java
FileHelper[OK].java.zip

[sylber-cz]

@sylber-cz here is my fileHelper.java
FileHelper[OK].java.zip

Thanks Robin, may I ask what version of cordova-plugin-camera are you running? Because I did a quick comparison of your and mine Filehelper.java file, and it seems like they are not equal with each other..

FileHelper.zip

[erisu]

There were some unnecessary cleanup, but code wise it LGTM.