fix(ios): tempFilePath called twice if using CameraUsesGeolocation #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
ios
Motivation and Context
When using
<preference name="CameraUsesGeolocation" value="true" />
, the image is saved twice and calls tempFilePath, which could cause an infinite loop as reported on #591 (couldn't reproduce)Description
Instead of doing as on #592, which put the timestamp check inside the while to fix the possible infinite loop, this PR fixes the problem of the image being saved twice.
It removes the while because it was there for an older code that used an int that was incremented until the file didn't exist and used that int for the image name. Now that uses the timestamp and it's not called twice there is no need for the while.
fixes #591
closes #592
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)