Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated file transfer plugin #634

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 23, 2020

Platforms affected

iOS

Motivation, Context & Description

Remove the broken deprecated File Transfer Plugin from test & its test,

@erisu erisu added this to the 5.0.0 milestone Jul 23, 2020
@erisu erisu requested a review from purplecabbage July 23, 2020 07:30
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it wasn't deprecated, not sure if having file-transfer tests in camera plugin makes sense, I guess that plugin already have upload tests

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a manual test, too. The backend (http://sheltered-retreat-43956.herokuapp.com/) seems broken, too.

@jcesarmobile
Copy link
Member

I loaded the url and says Hello!, so not sure if broken, didn't try to upload a picture, but it's not down

@timbru31
Copy link
Member

Oh indeed - my PiHole blocked the whole Heroku domain. Yeah it seems it's still alive. Approval remains though.

@erisu erisu merged commit 3f42591 into master Jul 23, 2020
@erisu erisu deleted the chore/remove-deprecated-file-transfer branch July 23, 2020 11:16
IT-MikeS pushed a commit to OutSystems/cordova-plugin-camera that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants