Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Android support for AndroidX #688

Closed
wants to merge 4 commits into from
Closed

Platform Android support for AndroidX #688

wants to merge 4 commits into from

Conversation

sieman
Copy link

@sieman sieman commented Nov 12, 2020

No description provided.

@sieman sieman closed this Nov 17, 2020
@sieman sieman reopened this Nov 17, 2020
@timbru31
Copy link
Member

Thanks Siegmar for your PR. We've already discussed AndroidX a bit and it's a tricky decision. On the one hand, if we go for AndroidX and enforce it, we will probably break a lot of plugins. But on the other hand, there might be some changes by Google that forces us to enable AndroidX nevertheless.

In the meantime you could use the cordova-plugin-androidx-adapter (which you probably already do).

See also apache/cordova-android#841 and the discussion on YT: https://www.youtube.com/watch?v=oarY6ZYj-CU, if interested.

@breautek breautek added this to the 6.0 milestone Feb 2, 2021
@noahcooper
Copy link

Any update on when this plugin might move to AndroidX? I'm sure I'm not alone in saying this -- this is now the only remaining plugin my apps use that requires the use of cordova-plugin-androidx-adapter.


<preference name="ANDROID_SUPPORT_V4_VERSION" default="27.+"/>
<framework src="com.android.support:support-v4:$ANDROID_SUPPORT_V4_VERSION"/>
<preference name="AndroidXEnabled" value="true" />
Copy link
Member

@NiklasMerz NiklasMerz Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As cordova-android 10 now comes with AndroidX by default those changes aren't really needed. I even got an error while building with the nightly version of cordova-android.

Failed to install 'cordova-plugin-camera': Error: Variable(s) missing: ANDROIDXENABLED
    at Object.mergeVariables (/Users/niklasmerz/.nvm/versions/node/v12.14.1/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/variable-merge.js:58:15)
    at /Users/niklasmerz/.nvm/versions/node/v12.14.1/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:302:44
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

@NiklasMerz NiklasMerz requested review from erisu and timbru31 July 14, 2021 14:02
@NiklasMerz
Copy link
Member

As cordova-android 10 now works only with AndroidX we should move forward with this.

@jcesarmobile
Copy link
Member

It was done in #751, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants