-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set applicationId #827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good overall change.
org.apache.cordova.BuildHelper is a utility class for accessing the app's BuildConfig
class, which is a class that is generated by gradle builds. It won't exist if the project happens.
Additionally the BuildHelper
class makes use of reflections, which can make debugging difficult and stacktraces mostly useless (since it will hard what you're trying to invoke).
Context.getPackageName is a SDK level 1 API which returns the same information as the OS knows it (powered by the AndroidManifest). It should be guaranteed to be accurate and available.
While the BuildHelper
class may have uses, if we can get the same information from concrete android APIs, I think that should be the more preferable approach 👍
Co-authored-by: Alexandre Alves <aalves@seamlink.com>
* fix(android): update queries in plugin.xml (apache#780) Solves the issue with duplicate queries elements in AppManifest.xml apache#779 * fix(ios): preserving EXIF data (apache#712) * ci(android): update java requirement for cordova-android@11 (apache#798) * dep(npm): bump package-lock v2 w/ rebuild (apache#800) * docs(README): Document ANDROIDX_CORE_VERSION variable (apache#808) * fix(browser): use navigator.mediaDevices.getUserMedia (apache#810) * ci: sync workflow with paramedic (apache#804) * fix(android): set applicationId (apache#827) Co-authored-by: Alexandre Alves <aalves@seamlink.com> * chore(android): Cleanup obsolete BuildConfig comments (apache#831) * ci(android): Drop API 22 & 31. Added API 24 & 33 (apache#835) Co-authored-by: エリス <erisu@users.noreply.github.com> * chore: bump plugin version 7.0.0-dev (apache#845) * dep(dev)!: bump @cordova/eslint-config@5.0.0 (apache#846) * dep(dev)!: bump @cordova/eslint-config@5.0.0 * chore: apply automatic lint fix * feat(android)!: Android 13 support (apache#844) * feat(android)!: Android 13 support * refactor(android): simplify getPermissions logic * feat(android)!: bump cordova-android requirement to >=12.0.0 * feat(android): update saveAlbumPermission to include Android 9 and below use case --------- Co-authored-by: ochakov <evgeny@ochakov.com> * chore: Update SUPPORT_QUESTION.md template (apache#849) * fix!: remove deprecated platforms (apache#848) * chore: remove windows/osx from plugin.xml (apache#850) * ci(gh-action): sync with paramedic configs (apache#851) * release(camera-v7.0.0): updated version and RELEASENOTES.md * chore: bump version 7.0.1-dev --------- Co-authored-by: Marcus Abrahamsson <marcus.abrahamsson13@gmail.com> Co-authored-by: Scott Murphy <scott@alwaysvip.com> Co-authored-by: エリス <erisu@users.noreply.github.com> Co-authored-by: jcesarmobile <jcesarmobile@gmail.com> Co-authored-by: seamlink-aalves <49952868+seamlink-aalves@users.noreply.github.com> Co-authored-by: Alexandre Alves <aalves@seamlink.com> Co-authored-by: Norman Breau <norman@nbsolutions.ca> Co-authored-by: ochakov <evgeny@ochakov.com> Co-authored-by: Erisu <erisu@apache.org>
Platforms affected
Motivation and Context
Description
Fix camera launcher #744
Testing
I invoked the camera plugin successfully
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)