-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android)!: access Context through webView.getContext() (CB-12623) #62
Conversation
The CordovaWebView object is not actually an Android WebView, so this shouldn't be done. |
@infil00p should we close this? |
@filmaj Not sure. I'm not sure what the reporter is trying to do here. |
@dreifachstein, could you elaborate please? |
Looks good to me, but you'll have to update engines in package.json and plugin.xml to require cordova-android >= 7.0.0 as this is not available in older versions And we on next plugin update should do a major bump because of the engines update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested in #62 (comment)
Let there be tests. |
We can bump the engines in a separate PR
I didn't see the engine requirement |
yeah, we can add it in a separate PR |
Android WebView can be created without an Activity. One use case is
to create a WebView within a Service and attach/detach it to an
Activity window on demand.