Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)!: access Context through webView.getContext() (CB-12623) #62

Closed
wants to merge 1 commit into from
Closed

Conversation

dreifachstein
Copy link
Contributor

Android WebView can be created without an Activity. One use case is
to create a WebView within a Service and attach/detach it to an
Activity window on demand.

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

66 tests run, 0 skipped, 0 failed.

@infil00p
Copy link
Member

infil00p commented Apr 23, 2017

The CordovaWebView object is not actually an Android WebView, so this shouldn't be done.

@filmaj
Copy link
Contributor

filmaj commented Apr 25, 2017

@infil00p should we close this?

@infil00p
Copy link
Member

infil00p commented May 1, 2017

@filmaj Not sure. I'm not sure what the reporter is trying to do here.

@janpio
Copy link
Member

janpio commented Aug 10, 2018

@dreifachstein, could you elaborate please?

@jcesarmobile
Copy link
Member

Looks good to me, but you'll have to update engines in package.json and plugin.xml to require cordova-android >= 7.0.0 as this is not available in older versions
apache/cordova-android@1790673

And we on next plugin update should do a major bump because of the engines update

@janpio janpio changed the title CB-12623: (android) access Context through webView.getContext() fix(android): access Context through webView.getContext() (CB-12623) Jul 4, 2019
janpio
janpio previously requested changes Jul 4, 2019
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in #62 (comment)

@janpio janpio closed this Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

Let there be tests.

@janpio janpio reopened this Jul 4, 2019
@jcesarmobile jcesarmobile requested a review from janpio May 14, 2024 00:23
@jcesarmobile jcesarmobile dismissed janpio’s stale review May 14, 2024 00:24

We can bump the engines in a separate PR

@jcesarmobile jcesarmobile changed the title fix(android): access Context through webView.getContext() (CB-12623) fix(android)!: access Context through webView.getContext() (CB-12623) May 14, 2024
@erisu
Copy link
Member

erisu commented May 14, 2024

I didn't see the engine requirement cordova-android >= 7.0.0 being added as requested.
Will we add it after this PR is merged?

@jcesarmobile
Copy link
Member

yeah, we can add it in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☠️ Closed/Abandoned
Development

Successfully merging this pull request may close these issues.

8 participants