doc: Improve progressEvent documentation #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes references of an undefined loadingStatus object and replaces it with comments or vanillaJS to improve clarity.
timbru31
approved these changes
Sep 23, 2020
MayankLogiciel
added a commit
to MayankLogiciel/cordova-plugin-file-transfer
that referenced
this pull request
Oct 5, 2020
* Add or update GitHub pull request and issue template * docs: undeprecate the plugin (apache#267) Co-authored-by: エリス <erisu@users.noreply.github.com> * fix(ios): re-implement user agent overwrite (apache#268) This closes apache#263 apache#258 * chore(npm): adds ignore list (apache#269) * fix!: remove deprecated platforms (apache#270) * chore: bump version to 2.0.0-dev (apache#273) * chore: package cleanup (apache#272) * refactor(eslint): use cordova-eslint /w fix (apache#275) * chore: adds package-lock file (apache#274) * doc: Improve progressEvent documentation (apache#280) Co-authored-by: Jan Piotrowski <piotrowski+git@gmail.com> Co-authored-by: Tim Brust <github@timbrust.de> Co-authored-by: エリス <erisu@users.noreply.github.com> Co-authored-by: Norman Breau <norman@normanbreau.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes references of an undefined loadingStatus object and replaces
it with comments or vanillaJS to improve clarity.
Platforms affected
Documentation
Motivation and Context
Improves documentation readability.
Closes #206
Description
Replaces usages of an undefined
loadingStatusobject in favour of comments and/or vanillaJS.Testing
N/A
Checklist
(platform)if this change only applies to one platform (e.g.(android))