Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ios): update workflow w/ iOS 15 #318

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 18, 2021

Platforms affected

iOS

Motivation, Context & Description

Previously all iOS test appeared to run only on iOS 14.4.

This PR:

  • Update GitHub Actions workflow to ensure that each defined iOS version was being tested correctly.
  • Included iOS 15.x to the workflow.

Testing

  • CI

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31
Copy link
Member

iOS 15 failed

@erisu
Copy link
Member Author

erisu commented Oct 19, 2021

The iOS failures are actual issues that need to be reviewed and fixed under a separate PR.

The goal of this PR was not to fix the iOS issues that were already existing but to accurately report what platform is breaking.

After the last run of this PR, you can see iOS 12 is also failing. Since failures will stop the entire workflow, all iOS versions may fail.

I will go ahead and merge in this PR to resolve the inaccurate testing and will also open a bug ticket for the current issues displayed in the log.

@erisu erisu merged commit 5c29f9a into apache:master Oct 20, 2021
@erisu erisu deleted the ci/ios-update branch October 20, 2021 04:27
dpalou pushed a commit to moodlemobile/cordova-plugin-file-transfer that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants