Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows)!: Drop Windows support #346

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

breautek
Copy link
Contributor

Platforms affected

Windows

Motivation and Context

Windows platform has been deprecated in favour for Electron.
This plugin still has browser support, which electron will use as a fallback.
As far as I can see in GitHub Actions, there are no tests for windows platform.
This plugin is far behind as it is, so may as well reduce our burden.

Description

Removes the windows proxy sources and drop the meta information in plugin.xml / package.json

Testing

Ran npm test, but that only runs eslint.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 2.x milestone Jul 22, 2022
@erisu erisu changed the title breaking(windows): Drop Windows support feat(windows)!: Drop Windows support Jul 12, 2023
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 04b6e4c into apache:master Jul 12, 2023
dpalou pushed a commit to moodlemobile/cordova-plugin-file-transfer that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants