refactor: shared eslint config #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breautek
changed the title
|
The failed check is due to an unrelated problem, which I'm going to solve in the WIP PR #460 Merging. |
40 tasks
pmcquay
pushed a commit
to BetterImpact/cordova-plugin-file
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
Motivation and Context
Previous eslint install was not compatible with Node 14.
Progresses apache/cordova#142
Progresses (but does not complete) apache/cordova#223
Description
Removed local eslint install in favour of the shared eslint provided by
@cordova/eslint-configTesting
Ran
npm testChecklist
(platform)if this change only applies to one platform (e.g.(android))