Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): support cdvfile assets for custom scheme #517

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 30, 2022

Platforms affected

android

Motivation and Context

cdvfile:// protocol is no longer supported and the assets file system was not working with recent changes to support the new cdvfile url pattern.

This PR is to support the assets file sytem

Description

Updated the WebViewAssetLoader.PathHandler to include assets

E.g. https://localhost/__cdvfile_assets__/ will map to app's assets /android_asset/

Testing

  • cordova build
  • cordova run
  • test specs

Checklist

  • I've run the tests to see all new and existing tests pass
  • I updated automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested review from NiklasMerz and breautek March 30, 2022 06:24
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants