Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(android): various cleanup #607

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 16, 2023

Platforms affected

android

Motivation and Context

Cleanup code and follow standards

Description

  • Corrected indention levels with Android Studio
  • Replaced mixing of tab indentions with spaces (VSCode)
  • Import Optimization with Android Studio
  • Removed a double caught exception.
  • Removed unused permissions global array variable
  • Move part of the permissions comment to hasReadPermission
  • Removed Trailing Spaces

For eaiser review, try enabling the Hide whitespace setting.

Testing

  • cordova plugin add ...
  • cordova build android
  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@erisu erisu merged commit c5bcbdf into apache:master Oct 17, 2023
5 of 10 checks passed
@erisu erisu deleted the refactor/android-202310 branch October 17, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants