Merge pull request #268 from wtrocki/CB-14048

CB-14048: (android) allowedSchemes check empty string fix
apache · May 19, 2018 · 33aff11 · 33aff11
2 parents 5581957 + 57eda78
commit 33aff11
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
@@ -1114,8 +1114,10 @@ else if (url.startsWith("sms:")) {
             // Test for whitelisted custom scheme names like mycoolapp:// or twitteroauthresponse:// (Twitter Oauth Response)
             else if (!url.startsWith("http:") && !url.startsWith("https:") && url.matches("^[a-z]*://.*?$")) {
                 if (allowedSchemes == null) {
-                    String allowed = preferences.getString("AllowedSchemes", "");
-                    allowedSchemes = allowed.split(",");
+                    String allowed = preferences.getString("AllowedSchemes", null);
+                    if(allowed != null) {
+                        allowedSchemes = allowed.split(",");
+                    }
                 }
                 if (allowedSchemes != null) {
                     for (String scheme : allowedSchemes) {