Skip to content

Commit

Permalink
fix!: remove deprecated platforms windows & osx (#1030)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcesarmobile committed Nov 4, 2023
1 parent 44ead0f commit 4b3c0f1
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 628 deletions.
24 changes: 0 additions & 24 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,20 +149,12 @@ instance, or the system browser.
- __toolbarposition__: Set to `top` or `bottom` (default is `bottom`). Causes the toolbar to be at the top or bottom of the window.
- __hidespinner__: Set to `yes` or `no` to change the visibility of the loading indicator (defaults to `no`).

Windows supports these additional options:

- __hidden__: set to `yes` to create the browser and load the page, but not show it. The loadstop event fires when loading is complete. Omit or set to `no` (default) to have the browser open and load normally.
- __hardwareback__: works the same way as on Android platform.
- __fullscreen__: set to `yes` to create the browser control without a border around it. Please note that if __location=no__ is also specified, there will be no control presented to user to close IAB window.


### Supported Platforms

- Android
- Browser
- iOS
- OSX
- Windows

### Example

Expand Down Expand Up @@ -364,17 +356,11 @@ function downloadListener(params){
- Android
- Browser
- iOS
- Windows
- OSX

### Browser Quirks

`loadstart`, `loaderror`, `message` events are not fired.

### Windows Quirks

`message` event is not fired.

### Quick Example

var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
Expand Down Expand Up @@ -405,7 +391,6 @@ The function is passed an `InAppBrowserEvent` object.
- Android
- Browser
- iOS
- Windows

### Quick Example

Expand All @@ -427,7 +412,6 @@ The function is passed an `InAppBrowserEvent` object.
- Android
- Browser
- iOS
- Windows

### Quick Example

Expand All @@ -447,7 +431,6 @@ The function is passed an `InAppBrowserEvent` object.
- Android
- Browser
- iOS
- Windows

### Quick Example

Expand All @@ -467,7 +450,6 @@ The function is passed an `InAppBrowserEvent` object.

- Android
- iOS
- Windows

### Quick Example

Expand Down Expand Up @@ -499,7 +481,6 @@ The function is passed an `InAppBrowserEvent` object.
- Android
- Browser
- iOS
- Windows

### Quick Example

Expand All @@ -512,10 +493,6 @@ The function is passed an `InAppBrowserEvent` object.

- only __code__ key is supported.

### Windows Quirks

Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.controls.webview.invokescriptasync.aspx) the invoked script can return only string values, otherwise the parameter, passed to __callback__ will be `[null]`.

## InAppBrowser.insertCSS

> Injects CSS into the `InAppBrowser` window. (Only available when the target is set to `'_blank'`)
Expand All @@ -534,7 +511,6 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont

- Android
- iOS
- Windows

### Quick Example

Expand Down
8 changes: 2 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@
"platforms": [
"android",
"browser",
"ios",
"osx",
"windows"
"ios"
]
},
"repository": "github:apache/cordova-plugin-inappbrowser",
Expand All @@ -24,9 +22,7 @@
"ecosystem:cordova",
"cordova-android",
"cordova-browser",
"cordova-ios",
"cordova-osx",
"cordova-windows"
"cordova-ios"
],
"scripts": {
"test": "npm run lint",
Expand Down
26 changes: 0 additions & 26 deletions plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -91,32 +91,6 @@
<framework src="CoreGraphics.framework" />
</platform>

<!-- osx -->
<platform name="osx">
<js-module src="www/inappbrowser.js" name="inappbrowser">
<clobbers target="cordova.InAppBrowser.open" />
</js-module>
<config-file target="config.xml" parent="/*">
<feature name="InAppBrowser">
<param name="osx-package" value="CDVInAppBrowser" />
</feature>
</config-file>

<header-file src="src/osx/CDVInAppBrowser.h" />
<source-file src="src/osx/CDVInAppBrowser.m" />
</platform>

<!-- windows -->
<platform name="windows">
<js-module src="www/inappbrowser.js" name="inappbrowser">
<clobbers target="cordova.InAppBrowser.open" />
</js-module>
<js-module src="src/windows/InAppBrowserProxy.js" name="InAppBrowserProxy">
<runs />
</js-module>
<asset src="www/inappbrowser.css" target="css/inappbrowser.css" />
</platform>

<!-- browser -->
<platform name="browser">
<js-module src="www/inappbrowser.js" name="inappbrowser">
Expand Down
30 changes: 0 additions & 30 deletions src/osx/CDVInAppBrowser.h

This file was deleted.

89 changes: 0 additions & 89 deletions src/osx/CDVInAppBrowser.m

This file was deleted.

Loading

0 comments on commit 4b3c0f1

Please sign in to comment.