Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14048: (android) allowedSchemes check empty string fix #268

Merged
merged 1 commit into from
May 19, 2018

Conversation

wtrocki
Copy link
Contributor

@wtrocki wtrocki commented Apr 26, 2018

Motivation

The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if AllowSchemes contains empty string after having being loaded, respectively only if null, which could lead to error in case a custom scheme is use but not set as white listed schema

What I mean is that, if no preference would be set in config.xml but a custom scheme would be used (my case) then the variable allowSchemes won't be null but will contains an empty string

Fix for https://issues.apache.org/jira/browse/CB-14048

@jcesarmobile jcesarmobile merged commit 33aff11 into apache:master May 19, 2018
@jcesarmobile
Copy link
Member

Merged.

Please @wtrocki, don't delete the PR templates and make sure you fill all the fields next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants