-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to next major release 6.0.0 #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In package.json this has to be updated to 7.0.0 or plugin will fail to update
cordova-plugin-inappbrowser/package.json
Line 45 in 839e2e2
"6.0.0": { |
I updated cli & ios to last major release. Is that correct? Android is not needed, yet I guess from the commits in master right? |
I don't think we need them to be latest, cordova-ios 6 supports the same iOS versions as cordova-ios 7. And for the CLI I'm not aware of any reason to bump it, maybe because of nodejs support? |
That sounds good to me. I set the same requirements and kept cli from the previous version. Thanks for the help @jcesarmobile. I never really dug into these requirements before. |
ae8968e
to
f802a5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Platforms affected
Motivation and Context
Prepare for next release
See list https://lists.apache.org/thread/p2ycdfv4tf0vnt1dbkv1160o5xz5knns
Description
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)