-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window #251
Conversation
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this assumes the existing app's window is UIWindowLevelNormal (good assumption of course), but to be really safe you should get its current level, then add one on top of that.
Get the current application's delegate (UIApplication sharedApplication
), then .window.windowLevel
on that to get the current app window's level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, this works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the solution with windowLevel
double baseWindowLevel = [UIApplication sharedApplication].keyWindow.windowLevel;
[tmpWindow setRootViewController:tmpController];
[tmpWindow setWindowLevel:baseWindowLevel+1];
@maltenorstroem , is the code snippet you posted what @shazron indicated in his earlier comment? |
@janpio Yes, exactly. |
Could you maybe create a new PR for this? |
#284 has been merged as an improved version of this. |
Platforms affected
iOS
What does this PR do?
Pushes the inappbrowser window to a new UI level to fix the magnifying glass.
What testing has been done on this change?
Tested on a device and simulator.
Checklist