Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window #251

Closed

Conversation

surajpindoria
Copy link
Member

@surajpindoria surajpindoria commented Nov 29, 2017

Platforms affected

iOS

What does this PR do?

Pushes the inappbrowser window to a new UI level to fix the magnifying glass.

What testing has been done on this change?

Tested on a device and simulator.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@surajpindoria surajpindoria changed the title CB-12875: (ios) Magnifiying glass is showing wrong content with inapp… CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window Nov 29, 2017
@asialatsushi
Copy link

👍

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this assumes the existing app's window is UIWindowLevelNormal (good assumption of course), but to be really safe you should get its current level, then add one on top of that.

Get the current application's delegate (UIApplication sharedApplication), then .window.windowLevel on that to get the current app window's level.

Copy link

@TheNaderio TheNaderio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this works great!

Copy link
Contributor

@maltenorstroem maltenorstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the solution with windowLevel

double baseWindowLevel = [UIApplication sharedApplication].keyWindow.windowLevel;
[tmpWindow setRootViewController:tmpController];
[tmpWindow setWindowLevel:baseWindowLevel+1];

@janpio
Copy link
Member

janpio commented Aug 16, 2018

@maltenorstroem , is the code snippet you posted what @shazron indicated in his earlier comment?

@maltenorstroem
Copy link
Contributor

@janpio Yes, exactly.

@janpio
Copy link
Member

janpio commented Aug 17, 2018

Could you maybe create a new PR for this?
I think the original PR poster is not around at this time.
Then we can merge that one and close this one.

@janpio
Copy link
Member

janpio commented Aug 21, 2018

#284 has been merged as an improved version of this.

@janpio janpio closed this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants