Cb 13969 - Allow close button and navigation buttons positions to be swapped #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom text on close button
…nal parameter to swap position of navigationbuttons and close/done button
steinaragustli
changed the title
steinaragustli
changed the title
…ption, reverting unneccesary indent changes on inappbrowser.css
|
I notice this is only implemented for the UIWebView variant of InappBrowser on iOS - can it be extended to the WKWebView variant as well? |
@dpa99c I will try that. I will let you know. |
|
@stevengill @agrieve @shazron @purplecabbage @jcesarmobile Is anyone able to review this ? It's a old pull request which i just updated. It's not a big change but enables some desirable additional functionality. |
|
Looks good. I'll have to test this before merging but I'll try to get to it this week. |
Ok awesome, thank you. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS and Android
What does this PR do?
Enables the position of the close/done button on inappbrowser to be swapped with the position of the navigation buttons. See https://issues.apache.org/jira/browse/CB-13969 for screenshots.
What testing has been done on this change?
I have tested all possible combination of parameters when different buttons are hidden and shown. So everything is consistent with how this should work.
Checklist