Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for right to left direction languages #353

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Add support for right to left direction languages #353

merged 1 commit into from
Mar 6, 2019

Conversation

transoceanic
Copy link
Contributor

@transoceanic transoceanic commented Nov 22, 2018 •
edited by purplecabbage
Loading

Platforms affected

Android

What does this PR do?

fix #352

What testing has been done on this change?

tested on Samsung Galaxy S7 (android 7.0), Nexus 5 (v6.0), Samsung Galaxy S5 (v4.4)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@transoceanic transoceanic changed the title Added to support android devices with right to left direction languag… Added support to android devices with right to left direction languag… Nov 22, 2018
@janpio janpio changed the title Added support to android devices with right to left direction languag… Add support for right to left direction languages Nov 22, 2018
@janpio
Copy link
Member

janpio commented Nov 22, 2018

Thanks for creating this PR!

I don't know much about Android, but that code looks good on first sight.
No idea what is going on with the tests though, might be broken in general right now - someone will have to look at this before we can merge this.

@purplecabbage purplecabbage merged commit 7b16ee8 into apache:master Mar 6, 2019
@purplecabbage purplecabbage mentioned this pull request Mar 6, 2019
Merged
purplecabbage added a commit that referenced this pull request Mar 6, 2019
@purplecabbage
Merge pull request #439 from apache/revert-353-patch-1
eb3acc0 
Revert "Add support for right to left direction languages"
I mistakenly merged #353 instead of a similar one.
@purplecabbage
Copy link
Contributor

Hi @transoceanic
I mistakenly merged this pr instead of another similar one.
You will need to rebase and resubmit this. Please @ mention me, and I will review it immediately.

@janpio janpio mentioned this pull request Jun 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug platform: android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't support android devices with right to left orientation languages
3 participants
@transoceanic @janpio @purplecabbage