-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update install engines #685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cordovaDependencies
is new to me, but changes make sense. 👍
Tests fail with:
Maybe the dependencies cannot be loaded because the -dev versions are not on NPM? |
Yeah, since this requires cordova-ios 6, test won’t work until it’s released. But better have it here so we don’t forget. |
Looks like I was wrong and cordova-ios 6 is not required for IAB to work, master is working fine on 5.1.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick test was good, too.
@@ -43,6 +43,10 @@ | |||
"cordova": ">=3.1.0" | |||
}, | |||
"4.0.0": { | |||
"cordova": ">=3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think minimum Cordova version should be increased as well, both here and in plugin.xml. I don't think we want to keep supporting old Cordova versions:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master version was bumped to 4.0.0-dev, so the package.json should have a new "5.0.0" entry or will fail to install once released.
Updated the "4.0.0" to require
cordova-ios >=6.0.0-dev
since the ios breaking changes will only work in that new version.Also updated the engine in
plugin.xml
for also requirecordova-ios >=6.0.0-dev
.Kept the
cordova >=3.1.0
as nothing was changed to require a newer version, but maybe we should require at least 9?