Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ios): fix regression in #656 #715

Merged
merged 1 commit into from
Jun 5, 2020
Merged

(ios): fix regression in #656 #715

merged 1 commit into from
Jun 5, 2020

Conversation

NiklasMerz
Copy link
Member

Platforms affected

iOS

Motivation and Context

Fix Merging issue from #656

Closes #714

Description

Remove method again

Testing

tested with building a wkwebview test app

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Merging issue from #656

Closes #714
@NiklasMerz NiklasMerz changed the title (ios): fix regression in 2706f34 (ios): fix regression in #656 Jun 5, 2020
@NiklasMerz NiklasMerz added this to the 4.0.0 milestone Jun 5, 2020
@mosabab
Copy link
Contributor

mosabab commented Jun 5, 2020

@NiklasMerz
Thanks for posting this PR.

But could you please check the previous PR for this fix:
It was changed 2 files . And your PR change only one file.

Please take a look into what was merged with this PR
https://github.com/apache/cordova-plugin-inappbrowser/pull/666/files

First file changes was:
src/ios/CDVInAppBrowserNavigationController.m

Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.

Second file is:
src/ios/CDVWKInAppBrowser.m

Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.

Just I post this to confirm if everything go in right way.

Regards

@NiklasMerz
Copy link
Member Author

As far as I can see the PR #656 just added the function in src/ios/CDVWKInAppBrowser.m. You can check that in 2706f34. So it did not revert all changes just this file which probably was a conflict.

@PDLMobileApps Could you please double check to make sure everything is correct?

Thanks everyone.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] No known instance method for selector 'shouldAutorotateToInterfaceOrientation:'
4 participants