ci(ios): remove wkwebview plugin #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
NiklasMerz
force-pushed
the
travis-xcode-update
branch
from
c630b95
to
b4eeb90
Compare
|
Build is now successful but simulator times out... |
|
I think it would be ideal if we could migrate to GitHub actions, like we have with cordova-ios. |
erisu
force-pushed
the
travis-xcode-update
branch
from
c8925e2
to
b040c34
Compare
timbru31
reviewed
Jul 9, 2020
erisu
force-pushed
the
travis-xcode-update
branch
from
86b7251
to
1095ae5
Compare
erisu
changed the title
NiklasMerz
changed the title
|
Repurposed the PR to remove the plugin and fix the tests again. |
timbru31
approved these changes
Nov 20, 2020
dpa99c
approved these changes
Nov 20, 2020
erisu
approved these changes
Nov 20, 2020
FE-Roger
pushed a commit
to hogangnono/cordova-plugin-inappbrowser
that referenced
this pull request
Sep 27, 2021
cordova-ios@6.x makes the WKWebView plugin obsolete. Co-authored-by: Erisu <ellis.bryan@gmail.com>
jessyefuster
pushed a commit
to jessyefuster/cordova-plugin-inappbrowser
that referenced
this pull request
Aug 16, 2023
cordova-ios@6.x makes the WKWebView plugin obsolete. Co-authored-by: Erisu <ellis.bryan@gmail.com>
pesi-hgc
pushed a commit
to pesi-hgc/cordova-plugin-inappbrowser-transparent
that referenced
this pull request
Nov 3, 2023
cordova-ios@6.x makes the WKWebView plugin obsolete. Co-authored-by: Erisu <ellis.bryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
See build issues in #688
Description
Since we are now testing against Cordova iOS 6.x we no longer need the WKWebView plugin in the test project. In fact this fixes the build again on Travis aside from Browser which is broken in all plugins for different reasons.
Testing
CI
Checklist
(platform)if this change only applies to one platform (e.g.(android))