Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): exit event not fired on swipe down #737

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Jun 19, 2020

Platforms affected

ios

Motivation and Context

fixes #718

Description

if presenting IAB on not full screen styles, when the user closes IAB using swipe down gesture instead of the close button the exit event is not fired

exit event is fired on viewDidDisappear, but only if isExiting is set to true, this PR uses the UIAdaptivePresentationControllerDelegate to detect when the modal is being dismissed and set isExiting to true so exit fires on viewDidDisappear

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcesarmobile jcesarmobile merged commit bdbb1df into apache:master Jun 22, 2020
@jcesarmobile jcesarmobile deleted the fix-exit-swipe branch June 22, 2020 09:44
@kartiksolanki
Copy link

Hi,
I tried above changes in my project and while the modal dismiss exit event is fired, I am now facing with UI presentation. So my modal has a close button and, when i do the presentation style to pagesheet (which appears like ios13 modal), the top navigation bar of the modal becomes transparent. I am attaching the image below for your reference.

Screenshot 2020-06-26 at 11 32 18

@kartiksolanki
Copy link

kartiksolanki commented Jun 26, 2020

Any idea what is going wrong in here? As you can see from the above screenshot, my modal top navigation appears as transparent on top of my default page calling the in app browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to catch event for presentationstyle=pagesheet close by swipe down?
3 participants