(ios) Add InAppBrowserStatusBarStyle preference #765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
This allows apps that set a dark status bar background color using cordova-plugin-statusbar to set the status bar style when using the in app browser. Became necessary after GH-656.
Fixes: #728
Description
Adds the ability to set
<preference name="InAppBrowserStatusBarStyle" value="lightcontent" />
in the config.xml file, so that thepreferredStatusBarStyle
becomesUIStatusBarStyleLightContent
instead ofUIStatusBarStyleDefault
.Testing
I created a test app and tried setting the InAppBrowserStatusBarStyle to "default", "lightcontent", and removing it alltogether. I didn't add any new automatic tests- not sure how.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)