Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated typings #817

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Updated typings #817

merged 2 commits into from
Nov 17, 2020

Conversation

wrightsonm
Copy link
Contributor

Updated the typings to reflect the latest version of the plugin
Closes #811

Platforms affected

n/a (js only)

Motivation and Context

typings do not compile correctly.
inappbrowser nolonger overrides window.open behaviour

Description

updated typings

Testing

used my updated typings file in my project.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31 timbru31 self-assigned this Nov 12, 2020
types/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Tim Brust <github@timbrust.de>
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge?

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timbru31 timbru31 merged commit 2e6d637 into apache:master Nov 17, 2020
@timbru31
Copy link
Member

Thanks all!

@wrightsonm
Copy link
Contributor Author

thanks @timbru31 .
what is the timeline for the next npm release?

@timbru31
Copy link
Member

We do not give any ETAs on new releases, but Niklas planned to make a new minor release soon

@NiklasMerz
Copy link
Member

I just prepared the release and we now need to wait for votes and the time to pass.

@wrightsonm Feel free to join the mailing list and vote on this release: Thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window.open typings file requires an update
5 participants