CB-8534: Add support for auth dialogs in inappbrowser plugin #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Is this pull request going to be in the cordova inappbrowser plugin soon? |
|
You could use cordova-plugin-auth-dialog with the webview instead of inAppBrowser. I just had to remove about 4 lines in a source xml file that was causing issues while building. Other than that it works great and i'm loving it. |
|
This change is required so that cordova-plugin-auth-dialog can work. I'll verify this change and merge |
|
Verified and merged |
|
@sgrebnov will this work for both ios and android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an authentication challenge is received, the inappbrowser will now check to see if a plugin can respond to the challenge before going to the default behavior. This is the same behavior that was added to cordova-android in CB-8201. It allows plugins like Auth Dialog to work with the inappbrowser.