breaking(android): replace magic numbers with android.os.Build constants #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbru31
reviewed
Nov 22, 2020
|
Yeah, this is just a revert of the previous commit where the magic numbers were introduced. |
5 tasks
FE-Roger
pushed a commit
to hogangnono/cordova-plugin-inappbrowser
that referenced
this pull request
Sep 27, 2021
jessyefuster
pushed a commit
to jessyefuster/cordova-plugin-inappbrowser
that referenced
this pull request
Aug 16, 2023
pesi-hgc
pushed a commit
to pesi-hgc/cordova-plugin-inappbrowser-transparent
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking because it won't compile in old cordova-android versions, engines should be updated to only allow cordova-android 9 and a major bump should be done on next release
Reverts #803