-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): make system open tel, sms, mailto and geo links #881
Conversation
That's unrelated to this PR, please, don't start off-topic conversations. If you want help, first thing you should do is make it easy to reproduce your issue, it's unclear what your problem is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LTGM
@mosabab Your comment was completely off-topic and @jcesarmobile was perfectly polite in his response. |
@mosabab, this pull request is about tel, sms, mailto and geo schemes not working on iOS when using the WKWebView. I also took the time to look into your issue, but it's not clear what your problem is by reading the description, so that's why I gave you the advice of improving it by providing a sample app. It's an advice, not telling you to do it, but you shouldn't demand a fix if you are not willing to collaborate by making it easy to reproduce. (It's also an advice, of course you can demand whatever you want) Thanks for the reviews! |
@jcesarmobile, are these changes published? I downloaded the latest version of cordova-plugin-inappbrowser which is 5.0.0 but it does not have these changes included. Any help is appreciated. |
Please, don’t ping me, I’m already subscribed to the issue, so you don’t need to ping me. 5.0.0 was released on Feb 10, 2021, this was merged on Jun 11, 2021l so no, it’s not included. you can always install from the GitHub url like |
any plans on publishing these latest changes in near future? |
I will start the discussion about a new relase on the mailing list now. I think I can take care of a new release in the near future, but please be patient for a little longer. |
Platforms affected
ios
Motivation and Context
closes #830
Description
UIWebView handled tel, sms, mailto and geo links, but WKWebView doesn't and if the site you are loading has any of those urls on links it will just try to load them and fail
android also has specific code for handling those app schemes
Testing
app with this code
cordova.InAppBrowser.open('https://www.parsippanysbestpizza.com/', '_blank');
has a mail link on top and telephone link on the bottom, without the fix they do nothing, with the fix mail link opens mail app and tel link prompts for making a call
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)