Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Implement 'animated' property (CB-11629) #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanwilliams83
Copy link

Platforms affected

iOS

What does this PR do?

Add property 'animated' to optionally disable native screen animations.
As iOS does not support the limit flag; capturing multiple images by calling
this plugin in a loop can be quite slow for end users.

What testing has been done on this change?

captureImage()
'animated' omitted / true / false

captureVideo()
'animated' omitted / true / false

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@janpio janpio changed the title CB-11629: (iOS) Implement 'animated' property and updated English docs feat(ios): Implement 'animated' property and updated English docs (CB-11629) Jul 4, 2019
@janpio janpio changed the title feat(ios): Implement 'animated' property and updated English docs (CB-11629) feat(ios): Implement 'animated' property (CB-11629) Jul 4, 2019
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard merge conflict, unsurprisingly after so much time.
Change could still be interesting though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants