Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for slow startup times #143

Closed
wants to merge 2 commits into from
Closed

Fix for slow startup times #143

wants to merge 2 commits into from

Conversation

TeamLinux01
Copy link

This changes the base couchdb image so that the find command that sets ownership to couchdb:couchdb does not have to change 1600+ files every time the container is started.

Overview

This allows containers based on the couchdb image to start being usable faster, as it does not have to apply new permissions on 1600+ files.

Related Pull Requests

#131
#132

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

This changes the base couchdb image so that the find command that sets ownership to couchdb:couchdb does not have to change 1600+ files every time the container is started.
This changes the base couchdb image so that the find command that sets ownership to couchdb:couchdb does not have to change 1600+ files every time the container is started.
@wohali
Copy link
Member

wohali commented Apr 29, 2019

@kocolosk comments? I thought we intentionally weren't doing this, but am failing to recall why. Need help.

@kocolosk
Copy link
Member

The fix from #132 is marginally better in that it makes for cheaper, faster image builds (but it needs to be applied to the files that were touched in this PR).

What we were trying to avoid was doing this blind chown -R at container startup time, as opposed to image build time. It does a lot of unnecessary work in both cases -- it's just much more painful at run time instead of build time 😄

@wohali
Copy link
Member

wohali commented Apr 29, 2019

Thanks @kocolosk

@TeamLinux01 Closing in favour of #132.

@wohali wohali closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants