-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pagination in ReplicatorDB activity panel #1288
base: main
Are you sure you want to change the base?
Conversation
- Update tests - Filter design docs with mango query
@garrensmith @Antonio-Maranhao Do I have to make some magic for partitioned database? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also found a couple of issues:
- The page crashes if
_replicator
DB doesn't exist - Polling interval loads a different page.
- E.g. while viewing the 3rd page with 5 docs/page (
_find
payload:{limit: 6, skip: 10, selector: {_id: {$gte: null}}}
), the results where refreshed but the query payload was for the 2nd page instead of the 3rd (i.e.{"limit":6,"skip":5,"selector":{"_id":{"$gte":null}}}
)
- E.g. while viewing the 3rd page with 5 docs/page (
- Change statusTime to startTime in table - Handle _replicatorDB not found - Fix replication reducer - Fix polling refresh
In inspected the commit a35a657 I have played with it a bit (I created 110 continuous replications to do so) and did not find anything wrong with it. So +1 from me, if that counts for anything. |
@popojargo sorry for the delay. I'll make time to review this today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my suggestion, just wanted to point out that column sorting and filtering only affect the docs in the current page, which I'm sure it'll mislead users.
Maybe it'd be worth adding a note at the top @popojargo @brianewilkins ?
Co-authored-by: Antonio Maranhao <30349380+Antonio-Maranhao@users.noreply.github.com>
Brainstorming here:
|
@popojargo I'd go with a note above the table. The tooltips are probably too repetitive as you said and less obvious. |
Overview
Add support for pagination in Replicatory activity panel.
Testing recommendations
GitHub issue number
Related Pull Requests
Supersed #1075
Checklist