Allow users to toggle word wrapping on the doc editor #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! |
fryjordan
suggested changes
Jun 13, 2024
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import Components from '../../../components/react-components'; | ||
| // import Constants from '../constants'; |
There was a problem hiding this comment.
Suggested change
| // import Constants from '../constants'; |
| @@ -39,6 +40,7 @@ export class StringEditModal extends React.Component { | |||
| this.editor = ace.edit(dom_node); | |||
| this.editor.setShowPrintMargin(false); | |||
| this.editor.setOption('highlightActiveLine', true); | |||
| this.editor.setOption('wrap', !!this.props.wordWrapEnabled); | |||
There was a problem hiding this comment.
This is on purpose to turn falsy/truthy values to false / true
| @@ -39,6 +40,7 @@ export class StringEditModal extends React.Component { | |||
| this.editor = ace.edit(dom_node); | |||
| this.editor.setShowPrintMargin(false); | |||
| this.editor.setOption('highlightActiveLine', true); | |||
| this.editor.setOption('wrap', !!this.props.wordWrapEnabled); | |||
There was a problem hiding this comment.
This is on purpose to turn falsy/truthy values to false / true
fryjordan
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow users to toggle word wrapping on the doc editor, which prevents horizontal scrolling on long lines.
Word wrap OFF
Word wrap ON
Testing recommendations
GitHub issue number
n/a
Related Pull Requests
n/a
Checklist