Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize lookup/3 #3386

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Optimize lookup/3 #3386

merged 1 commit into from
Feb 28, 2021

Conversation

rnewson
Copy link
Member

@rnewson rnewson commented Feb 27, 2021

A tidier version of #3384 that
saves an unnecessary call to collate.

@rnewson
Optimize lookup/3
45d4039 
A tidier version of #3384 that
saves an unnecessary call to collate.
@rnewson rnewson requested a review from davisp February 27, 2021 09:53
nickva
nickva approved these changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@nickva nickva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

The {traverse, ...} clause below could probably be similarly optimized to do the collate gt first then, based on the result, do lt, eq.

@rnewson rnewson merged commit a9e0ebe into main Feb 28, 2021
@rnewson rnewson deleted the ebtree-lookup-opt branch February 28, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickva nickva nickva approved these changes

@davisp davisp Awaiting requested review from davisp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnewson @nickva