Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov/codecov-action from 4.0.2 to 4.1.0 #1173

Conversation

tuxji
Copy link
Contributor

@tuxji tuxji commented Feb 29, 2024

(Replace incorrect tag 4.1.0 with v4.1.0)

Bumps codecov/codecov-action from 4.0.2 to 4.1.0.


updated-dependencies:

  • dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ...

(Replace incorrect tag 4.1.0 with v4.1.0)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.0.2...v4.1.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: John Interrante <interran@research.ge.com>
Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I guess codecov renamed the tag? Maybe we should start version pinning github actions with commit hashes instead tags if projects could change their tags. It looks like dependabot supports updating hashes and adds human readable comments so you know what versions is being used:

dependabot/dependabot-core#4691

@tuxji
Copy link
Contributor Author

tuxji commented Feb 29, 2024

I guess codecov renamed the tag? Maybe we should start version pinning github actions with commit hashes instead of tags if projects could change their tags.

Yes, commit hashes are immutable while tags can be changed willy-nilly. Most projects don't change their tags, but we just saw it happen in codecov's case so I agree a commit hash would have avoided this corrective PR. If we decide to switch to commit hashes, we'll have to create a JIRA issue and convert all the tags to hashes in a separate PR.

Meanwhile, here's my +1 approving this PR (officially I shouldn't approve/merge my own PR, but this is actually dependabot's PR needing a correction).

@tuxji tuxji merged commit 479d904 into apache:main Feb 29, 2024
9 checks passed
@tuxji tuxji deleted the dependabot/github_actions/codecov/codecov-action-4.1.0 branch February 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants