Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow-ballista] enable delete log periodically (#280) #285

Closed
wants to merge 4 commits into from

Conversation

Ted-Jiang
Copy link
Member

@Ted-Jiang Ted-Jiang commented Sep 26, 2022

Which issue does this PR close?

Closes #280.

add param cleanup_log_ttl in both executor and scheduler, means the number of hours to retain log files on each node, set zero means disable.

Rationale for this change

For now we are using tokio-tracing (also used in influx-iox, datafuse) to manage our tracing log. But there is not a feature like sl4j in java to delete our outdated log on disk. For long running application , we need manually delete them 😂, So before tokio-tracing support it, i think we need this feature.

What changes are included in this PR?

Are there any user-facing changes?

@Ted-Jiang Ted-Jiang force-pushed the issue_280 branch 2 times, most recently from 4834ba2 to dcaa001 Compare September 27, 2022 04:00
@Ted-Jiang
Copy link
Member Author

@andygrove PTAL

@andygrove
Copy link
Member

I'm not sure that we should be building log management features into Ballista. Perhaps it would be better to deploy a separate process alongside the executor to do this? Different companies will likely have different requirements here?

@Ted-Jiang
Copy link
Member Author

I'm not sure that we should be building log management features into Ballista. Perhaps it would be better to deploy a separate process alongside the executor to do this? Different companies will likely have different requirements here?

Yes, this is a temporary solution, it should be better handle by tokio-tracing(by now not). So i set default to 0 to disable this feature.

@yahoNanJing yahoNanJing mentioned this pull request Oct 28, 2022
9 tasks
@Ted-Jiang Ted-Jiang closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Enable enable delete log periodically.
2 participants