Skip to content

Commit

Permalink
Skip q72 for sort merge join
Browse files Browse the repository at this point in the history
  • Loading branch information
viirya committed Aug 6, 2024
1 parent dd4b5c6 commit cfe07aa
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ under the License.
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED
-Djdk.reflect.useDirectMethodHandle=false
</extraJavaTestArgs>
<argLine>-ea -Xmx6g -Xss4m ${extraJavaTestArgs}</argLine>
<argLine>-ea -Xmx4g -Xss4m ${extraJavaTestArgs}</argLine>
<additional.3_3.test.source>spark-3.3-plus</additional.3_3.test.source>
<additional.3_4.test.source>spark-3.4-plus</additional.3_4.test.source>
<additional.3_5.test.source>not-needed</additional.3_5.test.source>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import org.apache.comet.CometConf
class CometTPCDSQuerySuite
extends {
val tpcdsAllQueries: Seq[String] = Seq(
"q72",
"q1",
"q2",
"q3",
Expand Down Expand Up @@ -109,6 +108,7 @@ class CometTPCDSQuerySuite
"q69",
"q70",
"q71",
"q72",
"q73",
"q74",
"q75",
Expand Down Expand Up @@ -138,7 +138,6 @@ class CometTPCDSQuerySuite
"q99")

val tpcdsAllQueriesV2_7_0: Seq[String] = Seq(
"q72",
"q5a",
"q6",
"q10a",
Expand All @@ -163,6 +162,7 @@ class CometTPCDSQuerySuite
"q64",
"q67a",
"q70a",
"q72",
"q74",
"q75",
"q77a",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,13 @@ class CometTPCDSQueryTestSuite extends QueryTest with TPCDSBase with CometSQLQue
test(s"$name-v2.7") {
val goldenFile = new File(s"$baseResourcePath/v2_7", s"$name.sql.out")
joinConfs.foreach { conf =>
System.gc() // SPARK-37368
runQuery(queryString, goldenFile, conf)
val sortMergeJoin = sortMergeJoinConf != conf
// Skip q72 for sort-merge join because it uses too many resources
// that can cause OOM in GitHub Actions
if (!(sortMergeJoin && name == "q72")) {
System.gc() // SPARK-37368
runQuery(queryString, goldenFile, conf)
}
}
}
}
Expand Down

0 comments on commit cfe07aa

Please sign in to comment.