Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to stable Rust #142

Closed
Tracked by #369
sunchao opened this issue Feb 29, 2024 · 2 comments · Fixed by #505
Closed
Tracked by #369

Switch to stable Rust #142

sunchao opened this issue Feb 29, 2024 · 2 comments · Fixed by #505
Labels
enhancement New feature or request

Comments

@sunchao
Copy link
Member

sunchao commented Feb 29, 2024

What is the problem the feature request solves?

Comet currently uses nightly Rust because of two features:

  • int_roundings
  • specialization

We should investigate whether we can avoid depending on them and switch to stable Rust.

Describe the potential solution

No response

Additional context

No response
@sunchao sunchao added the enhancement New feature or request label Feb 29, 2024
@comphead
Copy link
Contributor

For int_roundings there is a thread to make it partially stable
rust-lang/rust#88581

@sunchao
Copy link
Member Author

sunchao commented Mar 21, 2024

We should be able to remove specialization easily at the moment.

@psvri psvri mentioned this issue Mar 24, 2024
Merged
@andygrove andygrove mentioned this issue May 2, 2024
Closed
13 tasks
@andygrove andygrove mentioned this issue Jun 3, 2024
Merged
himadripal pushed a commit to himadripal/datafusion-comet that referenced this issue Sep 7, 2024
@huaxingao
bump spark version to 3.4.3.2-apple (apache#142)
b5bbe5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Switch to stable Rust andygrove/datafusion-comet
2 participants
@sunchao @comphead