Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add tpcds-sf-1 to license header excluded list #108

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Feb 25, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Once the cache of generated tpcds data is used by CI, it will check license header for the files. We should exclude it too.

https://github.com/apache/arrow-datafusion-comet/actions/runs/8034989426/job/21947156559?pr=106

What changes are included in this PR?

How are these changes tested?

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now.

But we probably put the generated tpcds-sf-xx dir into the build or target dir in follow-up PRs, which are already excluded.

@viirya viirya merged commit d812bf0 into apache:main Feb 25, 2024
15 checks passed
@viirya viirya deleted the add_exclude branch February 25, 2024 06:49
@viirya
Copy link
Member Author

viirya commented Feb 25, 2024

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants