Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Spark-compatible CAST from string to integral types #307

Merged
merged 49 commits into from
May 1, 2024
Merged

feat: Implement Spark-compatible CAST from string to integral types #307

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
e674d03
Implement Spark-compatible cast from string to integral types
andygrove Apr 23, 2024
5628a3e
remove debug println
andygrove Apr 23, 2024
79633bc
update rust tests
andygrove Apr 23, 2024
004f431
clippy
andygrove Apr 23, 2024
7cf9816
more clippy
andygrove Apr 23, 2024
73cbe8f
minor refactort to reduce code duplication
andygrove Apr 23, 2024
32632c1
introduce accumulator
andygrove Apr 23, 2024
2ea4442
small refactor
andygrove Apr 23, 2024
d4fd8ff
introduce a macro
andygrove Apr 23, 2024
92029ba
remove overhead of trim on each string
andygrove Apr 23, 2024
85c646c
comment
andygrove Apr 23, 2024
89e8cca
remove spark from some method names
andygrove Apr 23, 2024
0f4da8f
rename some methods
andygrove Apr 23, 2024
8a856d7
Update core/src/execution/datafusion/expressions/cast.rs
andygrove Apr 23, 2024
7ff70d3
Merge branch 'cast-string-to-integral' of github.com:andygrove/arrow-…
andygrove Apr 23, 2024
8c87059
addressing feedback
andygrove Apr 23, 2024
1659a4c
bug fix
andygrove Apr 25, 2024
5d0730f
improve tests
andygrove Apr 25, 2024
074fddd
use checked math operations
andygrove Apr 25, 2024
818ab9c
fix regressions
andygrove Apr 25, 2024
4f2539d
improve tests
andygrove Apr 25, 2024
de87b5d
code cleanup
andygrove Apr 25, 2024
6cbc543
lint
andygrove Apr 25, 2024
1e5867c
Update spark/src/test/scala/org/apache/comet/CometCastSuite.scala
andygrove Apr 27, 2024
b283711
Update spark/src/test/scala/org/apache/comet/CometCastSuite.scala
andygrove Apr 27, 2024
9a51239
Update spark/src/test/scala/org/apache/comet/CometCastSuite.scala
andygrove Apr 27, 2024
0131005
Update spark/src/test/scala/org/apache/comet/CometCastSuite.scala
andygrove Apr 27, 2024
d9b1fb6
Update spark/src/test/scala/org/apache/comet/CometCastSuite.scala
andygrove Apr 27, 2024
317ea08
simplify the code by removing the i32/i64 specializaton via traits an…
andygrove Apr 27, 2024
efa7747
reimplement using generics
andygrove Apr 27, 2024
344c594
clippy
andygrove Apr 27, 2024
83ad6a2
add LargeUtf8 handling
andygrove Apr 27, 2024
6cea67f
add LargeUtf8 handling
andygrove Apr 27, 2024
ff70567
clippy
andygrove Apr 27, 2024
b7b6bfb
address feedback
andygrove Apr 27, 2024
2be0f9d
fix
andygrove Apr 27, 2024
659b191
Add criterion benchmark
andygrove Apr 28, 2024
52de3f1
optimize cast implementation to avoid copying string to chars (~60% f…
andygrove Apr 28, 2024
7196ea1
fix regression
andygrove Apr 28, 2024
b9ca5e2
Update core/src/execution/datafusion/expressions/cast.rs
andygrove Apr 29, 2024
4ab7c37
fix error in suggested code change
andygrove Apr 29, 2024
9906c91
address feedback
andygrove Apr 29, 2024
a8fada1
Update core/src/execution/datafusion/expressions/cast.rs
andygrove Apr 29, 2024
68a5f5d
cargo fmt
andygrove Apr 29, 2024
e5118db
add comments with references to Spark code that this code is based on
andygrove Apr 30, 2024
5ae2a8e
upmerge
andygrove Apr 30, 2024
60483eb
upmerge
andygrove May 1, 2024
3511d21
fix merge conflict
andygrove May 1, 2024
c42e326
fix merge conflict
andygrove May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading