Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cause to native exception #63

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Feb 20, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

We re-throw Java exception which is thrown in JVM during JNI calls. The re-thrown exception includes original exception class name and message but doesn't include cause. We should add the cause as sometimes the cause exception is root cause of the exception.

What changes are included in this PR?

How are these changes tested?

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit c74345b into apache:main Feb 21, 2024
6 checks passed
@viirya
Copy link
Member Author

viirya commented Feb 21, 2024

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants