chore: Use rust-toolchain.toml for better toolchain support #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
force-pushed
the
use-rust-toolchain-toml
branch
from
337e978 to
e187fae
Compare
34 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
============================================
- Coverage 33.62% 33.56% -0.06%
Complexity 827 827
============================================
Files 110 110
Lines 42555 42601 +46
Branches 9356 9347 -9
============================================
- Hits 14307 14297 -10
- Misses 25293 25352 +59
+ Partials 2955 2952 -3 ☔ View full report in Codecov by Sentry. |
andygrove
approved these changes
Jul 21, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Signed-off-by: Xuanwo <github@xuanwo.io> (cherry picked from commit 4de1adc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #698.
Rationale for this change
As mentioned in issue.
What changes are included in this PR?
Replace
rust-toolchainHow are these changes tested?
In every build.