fix: optimize isNullAt #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SF=100 Before
After
|
parthchandra
approved these changes
Jul 30, 2024
viirya
approved these changes
Jul 30, 2024
viirya
reviewed
Jul 30, 2024
| @@ -153,11 +153,7 @@ public CDataDictionaryProvider getDictionaryProvider() { | |||
|
|
|||
| @Override | |||
| public boolean isNullAt(int rowId) { | |||
| if (this.valueBufferAddress == -1) { | |||
There was a problem hiding this comment.
I'm surprised that Java compiler cannot optimize this.
andygrove
approved these changes
Jul 30, 2024
|
Thanks |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
(cherry picked from commit c4a06f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #679 and #670
Rationale for this change
This PR improves the isNullAt performance
What changes are included in this PR?
The new
isNullAtmethod uses the OR operator instead of the if clauseHow are these changes tested?
Existing tests