fix: Remove skip.surefire.tests
mvn property
#739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #404
Closes #.
Rationale for this change
The
skip.surefire.tests
property introduced in #404 causes-DskipTests
to not work formaven-surefire-plugin
.To skip only java tests we just add
-Dtest=none
.What changes are included in this PR?
skip.surefire.tests
and set failIfNoSpecifiedTests to false formaven-surefire-plugin
.How are these changes tested?
test
./mvnw install -DskipTests -pl common
before this pr (
-DskipTests
does not take effect):after this pr (
-DskipTests
takes effect):test
./mvnw test -Dtest=none -Dsuites="org.apache.comet.CometCastSuite valid"
after this pr (works well and only executes the specified suites):