Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize decimal creation macros #764

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

kazuyukitanimura
Copy link
Contributor

Which issue does this PR close?

Part of #679 and #670

Rationale for this change

This PR improves decimal creation macros

What changes are included in this PR?

Consolidated make_plain_decimal_impl to make_int_decimal_variant_impl

How are these changes tested?

Existing tests

@kazuyukitanimura
Copy link
Contributor Author

OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Mac OS X 14.5
Apple M1 Max
TPCDS Micro Benchmarks:                   Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
q44                                                2156           2293         157        133.7           7.5       1.0X
q44: Comet (Scan)                                  1968           2068         102        146.5           6.8       1.1X
q44: Comet (Scan, Exec)                            2264           2343          50        127.3           7.9       1.0

@kazuyukitanimura
Copy link
Contributor Author

Before

Screenshot 2024-08-01 at 11 22 56 PM

After

Screenshot 2024-08-01 at 11 23 16 PM

@kazuyukitanimura kazuyukitanimura marked this pull request as ready for review August 2, 2024 07:27
@kazuyukitanimura
Copy link
Contributor Author

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-08-05 15-56-33

👍

Consolidating the macros makes sense to me. Thanks @kazuyukitanimura.

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@andygrove andygrove merged commit d8ab910 into apache:main Aug 6, 2024
74 checks passed
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants