Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to DataFusion rev bddb641 and disable "skip partial aggregates" feature #788

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Aug 6, 2024

Which issue does this PR close?

N/A

Rationale for this change

Upgrade to latest DF

What changes are included in this PR?

  • Upgrade to latest DF
  • Disable new "skip partial aggregates" feature that was causing TPC-DS test failures
  • Other changes needed due to DF upgrade

How are these changes tested?

@andygrove andygrove requested a review from huaxingao August 6, 2024 23:54
@andygrove andygrove requested a review from viirya August 7, 2024 01:04
Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @andygrove

@andygrove andygrove merged commit c4bd3db into apache:main Aug 7, 2024
74 checks passed
@andygrove andygrove deleted the upgrade-df-skip-partial-agg branch August 7, 2024 03:52
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
…gregates" feature (apache#788)

* upgrade df version and disable skip partial agg

* add comment

* Save

* Revert debug changes

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants